Skip to content

[AMD][Qwen3.5] Update qwen3.5-fp4-mi355x-sglang-agentic-mtp SGLang ROCm image to v0.5.19-rocm720-mi35x-20260908 - #2906

Merged
adibarra merged 4 commits into
mainfrom
amd/qwen3.5-mxfp4-agentx-v0.5.19-20260908
Sep 11, 2026
Merged

[AMD][Qwen3.5] Update qwen3.5-fp4-mi355x-sglang-agentic-mtp SGLang ROCm image to v0.5.19-rocm720-mi35x-20260908#2906
adibarra merged 4 commits into
mainfrom
amd/qwen3.5-mxfp4-agentx-v0.5.19-20260908

Conversation

@yichiche

@yichiche yichiche commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=34299837777
see unofficial run visualizer at https://inferencex.semianalysis.com/evaluation?unofficialRun=34299837777

Summary

Update the SGLang ROCm image for the Qwen3.5 MXFP4 MI355X AgentX recipe from lmsysorg/sglang-rocm:v0.5.18-rocm720-mi35x-20260829 to lmsysorg/sglang-rocm:v0.5.19-rocm720-mi35x-20260908.

Recipes touched: qwen3.5-fp4-mi355x-sglang-agentic-mtp

The target tag was verified to exist on Docker Hub under lmsysorg/sglang-rocm (HTTP 200). Note that the ROCm-suffixed tag does not exist under lmsysorg/sglang.

Test plan

  • The full-sweep-fail-fast sweep passes.

Note

Low Risk
Config-only Docker image pin and changelog; no application logic, auth, or data-path changes.

Overview
Updates the agentic-coding benchmark recipe qwen3.5-fp4-mi355x-sglang-agentic-mtp to pull a newer SGLang ROCm container: lmsysorg/sglang-rocm:v0.5.18-rocm720-mi35x-20260829lmsysorg/sglang-rocm:v0.5.19-rocm720-mi35x-20260908. Model, runner, MTP search space, and HiCache arms are unchanged.

Adds a matching perf-changelog entry (config key + agentic-coding scenario) so the image bump is tracked for performance history.

Reviewed by Cursor Bugbot for commit 79c3f04. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-fail-fast label (strongly recommended) to this PR — the benchmark sweep only runs on labeled PRs. Use full-sweep-enabled only if you need matrix jobs to keep running past a failure.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-fail-fast 标签(强烈推荐)— 基准测试 sweep 仅在带有标签的 PR 上运行。仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

…Cm image to v0.5.19-rocm720-mi35x-20260908

Co-Authored-By: ChangLiu0709 <190883410+ChangLiu0709@users.noreply.github.com>
@yichiche yichiche changed the title [AMD][Qwen3.5] Update qwen3.5-fp4-mi355x-sglang-agentic-mtp SGLang ROCm image to v0.5.19-rocm720-mi35x-20260908 / 升级 qwen3.5-fp4-mi355x-sglang-agentic-mtp 的 SGLang ROCm 镜像至 v0.5.19-rocm720-mi35x-20260908 [AMD][Qwen3.5] Update qwen3.5-fp4-mi355x-sglang-agentic-mtp SGLang ROCm image to v0.5.19-rocm720-mi35x-20260908 Sep 9, 2026
@yichiche
yichiche force-pushed the amd/qwen3.5-mxfp4-agentx-v0.5.19-20260908 branch from d5db3f5 to f8205d6 Compare September 9, 2026 01:35
@github-actions

This comment was marked as outdated.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, straightforward image version bump.
Reviewed: the configs/amd-master.yaml change is a single-field image tag bump for qwen3.5-fp4-mi355x-sglang-agentic-mtp, with multinode: false so the srt-slurm container/image invariant doesn't apply; confirmed no other fields changed. Confirmed the perf-changelog.yaml entry is appended at the tail only, follows the existing kebab-case schema, and matches the image change described.

Extended reasoning...

Overview

This PR bumps the Docker image tag for the qwen3.5-fp4-mi355x-sglang-agentic-mtp recipe in configs/amd-master.yaml from v0.5.18-rocm720-mi35x-20260829 to v0.5.19-rocm720-mi35x-20260908, and appends a matching entry to perf-changelog.yaml. Verified via git diff that only the image: line changed in the config (all other fields — model, precision, framework, scenarios, multinode: false — are untouched), and the changelog addition is a well-formed append at the very end of the file with no modification to existing bytes.

Security risks

None. This is a version-tag change to a config value consumed by the benchmark harness; no code execution paths, auth, or crypto are touched.

Level of scrutiny

Low. This matches the repository's established pattern for "simple, mechanical" changes explicitly called out as approvable: a version bump with no logic changes, correctly paired with the required changelog entry. multinode: false means the srt-slurm "container must equal image" cross-file invariant does not apply, so there's no additional consistency check needed across recipe/master config files.

Other factors

No bug-hunter findings, no PR conversation objections, and the PR author's own description matches what the diff actually does. AGENTS.md's core requirements (changelog entry present, append-only preserved, kebab-case fields) are satisfied.

This review covers commit fa8db9f, which is no longer the latest commit on this pull request; later commits are not covered by it.

@github-actions

This comment was marked as outdated.

5 similar comments
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@1am9trash

Copy link
Copy Markdown
Collaborator

/reuse-sweep-run 34299837777

@1am9trash

1am9trash commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator
image

@1am9trash 1am9trash left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a PR reviewer and CODEOWNER, I have reviewed this and have:

  • Verified that as of the moment of typing this, this is the latest version of PR_REVIEW_CHECKLIST.md
  • Verified that the general code quality meets the InferenceX standard and does not make the code quality any worse.
  • Verified that this PR has passed PR validation. Please link to GitHub Action workflow that shows this. Link: https://inferencex.semianalysis.com/inference?unofficialRun=34299837777
  • Verified that this PR passes evals. Please link to GitHub Action workflow that shows this. Link: https://inferencex.semianalysis.com/evaluation?unofficialRun=34299837777
  • Verified that speculative decoding PRs uses chat templates to align the AL distribution to real world
  • For agentic workloads: verified that speculative-decoding configs (EAGLE / MTP / draft models) run with simulated synthetic acceptance, with the acceptance-length value taken from the committed golden AL curve in golden_al_distribution/ for that model, thinking mode, and draft length. A submission may choose any supported draft length, but it may not substitute a different acceptance target.
  • Verified against the current MODELS.md that this PR does not submit a deprecated model, scenario, or model-scenario combination.
  • Verified that the model architecture isn't changed with benchmark hacks like using --hf-overrides to skipping indexer for every x layers on models that don't natively support this. As a general rule, we won't accept optimizations that reduces the number of model architecture FLOPs. Anything that makes that same computation run faster is fair game; FLOPs at lower precisions is fine, given that the config passes private evals. As an general north star princple, we should only use optimizations which is used in production by customers that care about accuracy
  • If an company claims that they support vLLM/SGLang as first class LLM inference engines on their hardware, I have verified that the respective vLLM submission made using upstream https://hub.docker.com/u/vllm docker repo, upstream SGLang https://hub.docker.com/u/lmsysorg docker repo. The only exceptions are for new hardware, such as MI455X UALoE72, Vera Rubin NVL72, Rubin NVL8, etc., and for new model architectures where there is an actual reason why vLLM/SGLang does not fundamentally support them yet as supported by vLLM/SGLang community maintainers
  • If an company claims that they support vLLM/SGLang as first class upstream in-tree LLM inference engines on their hardware, I have have verified that the respective vLLM/SGLang submission has been made before additional frameworks (TRT-LLM, ATOM, etc.). The only exceptions are for new hardware, such as MI455X UALoE72, Vera Rubin NVL72, Rubin NVL8, etc., and for new model architectures where there is an actual reason why vLLM/SGLang does not fundamentally support them yet.
  • Verified that every single-node vLLM/SGLang recipe in this PR is documented in the official vLLM recipes and/or the SGLang cookbook:
    • I linked the corresponding upstream PR in the vLLM recipe repo or SGLang repo and verified that it is MERGED before this InferenceX PR merges. An opened, draft, or closed-without-merge upstream PR does not satisfy this requirement. If the matching recipe was already published, I linked the published recipe/cookbook page in the additional detail section below.
  • Verified that this PR does not patch the inference engine or serving stack — the pinned image must run as shipped. This covers .patch files / git apply / patch, inline patches embedded in benchmark scripts (e.g. a python3/sed heredoc that rewrites installed engine sources before serving), in-place edits of site-packages, monkey-patching, overwriting container files, and installing forked/rebuilt engine wheels on top of the pinned image. The only exception is a patch covered by a filled-out waiver at docs/waiver/<PR_NUMBER>.md — named after the PR that introduces the patch and filed in that same PR, stating what is patched, why the unmodified upstream image cannot run this benchmark, the upstream PR/issue link, and the removal plan — which I have linked below in the additional detail section.
  • If this PR uses append-only: true, verified that it only adds generated points or recipe variants inside a selected existing config/scenario and existing same-image visual curve: every previously generated point remains present with the same recipe, no prior point is removed or rerun, and every benchmark-affecting change in the complete diff can affect only the corresponding newly appended points (never an existing point), regardless of which file contains it.
  • If any of the above criteria cannot reasonably be satisfied, I have provided additional reasoning below.

Additional detail section:

Signed: @1am9trash

@Klaud-Cold

Copy link
Copy Markdown
Collaborator

✅✅✅ Verdict: PASS ✅✅✅

✅ Check 0 (CODEOWNER): PASS — @1am9trash is a named owner of configs/amd-master.yaml; perf-changelog.yaml is catch-all only.
✅ Check 1 (Sweep on in-PR commit): PASS — in-PR commit f8205d6 has 28 executed agentic / jobs + agentic eval / all success in run 34299837777 (fixed-seq single-node */ / eval / lanes skipped because this config is agentic-only). Head 7b55423 is the signed-off SHA.
✅ Check 2 (Evals pass): PASS — agg_eval_all.json: gsm8k em_strict 0.978 (n=1319) ≥ 0.94 Qwen3.5 bar in utils/evals/thresholds.yaml; eval job ran the PR image lmsysorg/sglang-rocm:v0.5.19-rocm720-mi35x-20260908.
✅ Check 3 (Recipe linked/merged/matches): PASS — SGLang cookbook Qwen3.5 is published; its MI355X MXFP4 branch is merged in sgl-project/sglang main (#35445, #36245). Major args match: amd/Qwen3.5-397B-A17B-MXFP4, TP2 (cookbook: tp=4 for low concurrency), EP1/DP1 defaults, --attention-backend aiter, --kv-cache-dtype fp8_e4m3, MTP steps 3 / topk 1 / draft 4 (EAGLE = cookbook NEXTN alias), identical HiCache flags, ROCM_QUICK_REDUCE_QUANTIZATION=INT8 + AITER envs. Informational only: --scheduler-recv-interval, --chunked-prefill-size, --cuda-graph-max-bs, --max-running-requests, --stream-interval, simulate-acc envs, image tag.
✅ Check 4 (Reuse command): PASS — /reuse-sweep-run 34299837777 posted by 1am9trash (COLLABORATOR).
✅ Check 5 (Latest template): PASS — all 14 items + the merged-upstream sub-item of the current docs/PR_REVIEW_CHECKLIST.md are present and checked.
✅ Check 6 (Upstream image / engine-first): PASS — framework: sglang on MI355X uses upstream lmsysorg/sglang-rocm:v0.5.19-rocm720-mi35x-20260908; engine-first ordering N/A for an SGLang entry.
✅ Check 7 (Deprecated models): PASS — qwen3.5 fp4 agentic-coding MTP is active in MODELS.md as of 2026-09-10 (fp8/fp4 remain; MTP is the published arm).
✅ Check 8 (No architecture hacks): PASS — diff is an image-tag bump + changelog entry; no --hf-overrides / override args in the unchanged launch script.
✅ Check 9 (Spec-decode chat template): PASS — qwen3.5_fp4_mi355x_sglang_mtp.sh replays with --apply-chat-template.
✅ Check 10 (No engine patches): PASS — no patch files, heredoc rewrites, site-packages edits, or engine wheel installs; no waiver needed.
✅ Check 11 (Agentic golden AL): PASS — SGLANG_SIMULATE_ACC_LEN=3.39 with match-expected / real-draft-token, matching golden_al_distribution/qwen3.5_mtp.yaml thinking_on K=3 (3 speculative steps); evals run with real verification. Non-agentic sibling configs untouched.
➖ Check 12 (Append-only): N/A — the new perf-changelog.yaml entry does not set append-only: true.

@yichiche

Copy link
Copy Markdown
Collaborator Author

Hi @cquil11 @adibarra, May you help review this regular image update for qwen3.5 mxfp4 agent mode on MI355? Many thanks.

@adibarra
adibarra merged commit 3343b82 into main Sep 11, 2026
30 checks passed
@adibarra
adibarra deleted the amd/qwen3.5-mxfp4-agentx-v0.5.19-20260908 branch September 11, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

5 participants