[AMD][Qwen3.5] Update qwen3.5-fp4-mi355x-sglang-agentic-mtp SGLang ROCm image to v0.5.19-rocm720-mi35x-20260908 - #2906
Conversation
|
Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase For PR verification, add the PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs 感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 如需进行 PR 验证,请为此 PR 添加 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档 |
fa8db9f to
d5db3f5
Compare
…Cm image to v0.5.19-rocm720-mi35x-20260908 Co-Authored-By: ChangLiu0709 <190883410+ChangLiu0709@users.noreply.github.com>
d5db3f5 to
f8205d6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Looks good, straightforward image version bump.
Reviewed: the configs/amd-master.yaml change is a single-field image tag bump for qwen3.5-fp4-mi355x-sglang-agentic-mtp, with multinode: false so the srt-slurm container/image invariant doesn't apply; confirmed no other fields changed. Confirmed the perf-changelog.yaml entry is appended at the tail only, follows the existing kebab-case schema, and matches the image change described.
Extended reasoning...
Overview
This PR bumps the Docker image tag for the qwen3.5-fp4-mi355x-sglang-agentic-mtp recipe in configs/amd-master.yaml from v0.5.18-rocm720-mi35x-20260829 to v0.5.19-rocm720-mi35x-20260908, and appends a matching entry to perf-changelog.yaml. Verified via git diff that only the image: line changed in the config (all other fields — model, precision, framework, scenarios, multinode: false — are untouched), and the changelog addition is a well-formed append at the very end of the file with no modification to existing bytes.
Security risks
None. This is a version-tag change to a config value consumed by the benchmark harness; no code execution paths, auth, or crypto are touched.
Level of scrutiny
Low. This matches the repository's established pattern for "simple, mechanical" changes explicitly called out as approvable: a version bump with no logic changes, correctly paired with the required changelog entry. multinode: false means the srt-slurm "container must equal image" cross-file invariant does not apply, so there's no additional consistency check needed across recipe/master config files.
Other factors
No bug-hunter findings, no PR conversation objections, and the PR author's own description matches what the diff actually does. AGENTS.md's core requirements (changelog entry present, append-only preserved, kebab-case fields) are satisfied.
This review covers commit fa8db9f, which is no longer the latest commit on this pull request; later commits are not covered by it.
This comment was marked as outdated.
This comment was marked as outdated.
5 similar comments
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=34299837777 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=34299837777 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=34299837777 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=34299837777 |
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=34299837777 |
|
/reuse-sweep-run 34299837777 |
1am9trash
left a comment
There was a problem hiding this comment.
As a PR reviewer and CODEOWNER, I have reviewed this and have:
- Verified that as of the moment of typing this, this is the latest version of PR_REVIEW_CHECKLIST.md
- Verified that the general code quality meets the InferenceX standard and does not make the code quality any worse.
- Verified that this PR has passed PR validation. Please link to GitHub Action workflow that shows this. Link: https://inferencex.semianalysis.com/inference?unofficialRun=34299837777
- Verified that this PR passes evals. Please link to GitHub Action workflow that shows this. Link: https://inferencex.semianalysis.com/evaluation?unofficialRun=34299837777
- Verified that speculative decoding PRs uses chat templates to align the AL distribution to real world
- For agentic workloads: verified that speculative-decoding configs (EAGLE / MTP / draft models) run with simulated synthetic acceptance, with the acceptance-length value taken from the committed golden AL curve in golden_al_distribution/ for that model, thinking mode, and draft length. A submission may choose any supported draft length, but it may not substitute a different acceptance target.
- Verified against the current MODELS.md that this PR does not submit a deprecated model, scenario, or model-scenario combination.
- Verified that the model architecture isn't changed with benchmark hacks like using --hf-overrides to skipping indexer for every x layers on models that don't natively support this. As a general rule, we won't accept optimizations that reduces the number of model architecture FLOPs. Anything that makes that same computation run faster is fair game; FLOPs at lower precisions is fine, given that the config passes private evals. As an general north star princple, we should only use optimizations which is used in production by customers that care about accuracy
- If an company claims that they support vLLM/SGLang as first class LLM inference engines on their hardware, I have verified that the respective vLLM submission made using upstream https://hub.docker.com/u/vllm docker repo, upstream SGLang https://hub.docker.com/u/lmsysorg docker repo. The only exceptions are for new hardware, such as MI455X UALoE72, Vera Rubin NVL72, Rubin NVL8, etc., and for new model architectures where there is an actual reason why vLLM/SGLang does not fundamentally support them yet as supported by vLLM/SGLang community maintainers
- If an company claims that they support vLLM/SGLang as first class upstream in-tree LLM inference engines on their hardware, I have have verified that the respective vLLM/SGLang submission has been made before additional frameworks (TRT-LLM, ATOM, etc.). The only exceptions are for new hardware, such as MI455X UALoE72, Vera Rubin NVL72, Rubin NVL8, etc., and for new model architectures where there is an actual reason why vLLM/SGLang does not fundamentally support them yet.
- Verified that every single-node vLLM/SGLang recipe in this PR is documented in the official vLLM recipes and/or the SGLang cookbook:
- I linked the corresponding upstream PR in the vLLM recipe repo or SGLang repo and verified that it is MERGED before this InferenceX PR merges. An opened, draft, or closed-without-merge upstream PR does not satisfy this requirement. If the matching recipe was already published, I linked the published recipe/cookbook page in the additional detail section below.
- Verified that this PR does not patch the inference engine or serving stack — the pinned image must run as shipped. This covers .patch files / git apply / patch, inline patches embedded in benchmark scripts (e.g. a python3/sed heredoc that rewrites installed engine sources before serving), in-place edits of site-packages, monkey-patching, overwriting container files, and installing forked/rebuilt engine wheels on top of the pinned image. The only exception is a patch covered by a filled-out waiver at docs/waiver/
<PR_NUMBER>.md— named after the PR that introduces the patch and filed in that same PR, stating what is patched, why the unmodified upstream image cannot run this benchmark, the upstream PR/issue link, and the removal plan — which I have linked below in the additional detail section. - If this PR uses
append-only: true, verified that it only adds generated points or recipe variants inside a selected existing config/scenario and existing same-image visual curve: every previously generated point remains present with the same recipe, no prior point is removed or rerun, and every benchmark-affecting change in the complete diff can affect only the corresponding newly appended points (never an existing point), regardless of which file contains it. - If any of the above criteria cannot reasonably be satisfied, I have provided additional reasoning below.
Additional detail section:
- Cookbook is at: https://docs.sglang.io/cookbook/autoregressive/Qwen/Qwen3.5
Signed: @1am9trash
✅✅✅ Verdict: PASS ✅✅✅✅ Check 0 (CODEOWNER): PASS — |

see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=34299837777
see unofficial run visualizer at https://inferencex.semianalysis.com/evaluation?unofficialRun=34299837777
Summary
Update the SGLang ROCm image for the Qwen3.5 MXFP4 MI355X AgentX recipe from
lmsysorg/sglang-rocm:v0.5.18-rocm720-mi35x-20260829tolmsysorg/sglang-rocm:v0.5.19-rocm720-mi35x-20260908.Recipes touched:
qwen3.5-fp4-mi355x-sglang-agentic-mtpThe target tag was verified to exist on Docker Hub under
lmsysorg/sglang-rocm(HTTP 200). Note that the ROCm-suffixed tag does not exist underlmsysorg/sglang.Test plan
full-sweep-fail-fastsweep passes.Note
Low Risk
Config-only Docker image pin and changelog; no application logic, auth, or data-path changes.
Overview
Updates the agentic-coding benchmark recipe
qwen3.5-fp4-mi355x-sglang-agentic-mtpto pull a newer SGLang ROCm container:lmsysorg/sglang-rocm:v0.5.18-rocm720-mi35x-20260829→lmsysorg/sglang-rocm:v0.5.19-rocm720-mi35x-20260908. Model, runner, MTP search space, and HiCache arms are unchanged.Adds a matching perf-changelog entry (config key +
agentic-codingscenario) so the image bump is tracked for performance history.Reviewed by Cursor Bugbot for commit 79c3f04. Bugbot is set up for automated code reviews on this repo. Configure here.